Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicated annotator definition [IDE-192] #489

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

bastiandoetsch
Copy link
Collaborator

Description

Apparently specifying one annotator with language "" is sufficient for any language. Also fixed late initialization of issues, to not be done in UI thread.

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@bastiandoetsch bastiandoetsch requested a review from a team as a code owner March 13, 2024 07:58
Apparently "" is sufficient for any language.
@bastiandoetsch bastiandoetsch force-pushed the fix/IDE-192_issues-are-annotated-twice branch from e1ac560 to 912ba61 Compare March 13, 2024 08:02
Copy link
Contributor

@acke acke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@bastiandoetsch bastiandoetsch merged commit 63546a6 into master Mar 13, 2024
8 checks passed
@bastiandoetsch bastiandoetsch deleted the fix/IDE-192_issues-are-annotated-twice branch March 13, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants